Repository navigation
fix(build): update Robolectric to 4.18.1 for Linux arm64 - #206
Merged
Merged
Conversation
Robolectric 4.16 has no native runtime for Linux aarch64, so every @GraphicsMode(NATIVE) test failed at startup there. 4.18 adds the aarch64 libraries (nativeruntime-dist-compat 1.0.20). 4.18.1's DefaultSdkProvider expects android-all-instrumented 15-robolectric-14663667-2-i7 for API 35; API 34 is unchanged. The parity docs that name the version are updated too. Verified: scripts/check.sh passes on the Android VM (x86_64) with 3,667 tests, 0 failures, 3 skipped, the same tests and statuses as dev. On aarch64 (Temurin 17 under qemu), ImageDrawingTests failed with 4.16 as reported and the media native graphics classes pass with 4.18.1 (21/21).
|
You're welcome! I'd love to contribute more to the project. Would you be open to having me as a regular contributor? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #194
Robolectric 4.16 has no native runtime for Linux arm64, so every
@GraphicsMode(NATIVE)test fails there. 4.18 adds one (release notes). This updates Robolectric to 4.18.1 and the API 35android-all-instrumentedjar to the build itsDefaultSdkProviderexpects (API 34 is unchanged), plus the two parity docs that name the version.scripts/check.shpasses on the VM with 3,667 tests, 0 failures and 3 skipped, the same tests and results asdev. The VM is x86_64, so I checked arm64 in an emulated aarch64 JDK 17 container:ImageDrawingTestsfails with 4.16 as reported, and the media native graphics tests pass with 4.18.1. The full suite on real arm64 hardware relies on the reporter's run.Thanks @kacigaya for the diagnosis.